Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4 #323

Merged
merged 53 commits into from
Apr 12, 2021
Merged

Release 2.4 #323

merged 53 commits into from
Apr 12, 2021

Conversation

filipenevola
Copy link
Collaborator

@filipenevola filipenevola commented Mar 19, 2021

As we have many big PRs right now in progress we are grouping them in this branch.

This branch was started from hot-module-replacement branch.

Beta

beta.3 is out. Our goal is to have beta.3 as our latest beta.

How to test 2.4

meteor add blaze-html-templates@1.2.0-beta.3

How to test 2.4 with HMR

You can try this integration in apps using Meteor 2 or newer by running:

meteor add hot-module-replacement blaze-html-templates@1.2.0-beta.3

To also use HMR for javascript files that use the Template api, run

meteor add blaze-hot

brucejo75 and others added 30 commits December 11, 2017 05:27
- Updates all root views instead of only the body view
- still detects duplicate templates when HMR is enabled
As HTML.TransformingVisitor would not visit the elements within
each block tag, the OptimisingVisitor would skip a portion of
the templates.
Resolves an issue where RawCompactingVisitor would not
recurse through any nested elements.
@filipenevola
Copy link
Collaborator Author

Hi @nathan-muir @brucejo75 @zodern could you help me with the https://github.com/meteor/blaze/blob/master/HISTORY.md updates for 2.4?

As we have many changes here would be important to highlight first important changes that could affect app behavior.

Thanks

@brucejo75
Copy link
Contributor

submitted #325

@nathan-muir
Copy link
Contributor

#319 Fixed a few situations where the template compiler wouldn't optimise it's output javascript.

Should make rendering faster (if the initial optimisation reasoning holds true)

#321 Just source code modernisation, making it easier to read. Shouldn't change any API's; except may need explicit import if other packages are using directly.

#324 Add a whitespace="strip" option to templates, which removes any whitespace that crosses newlines.

@filipenevola filipenevola added this to the 2.4 milestone Mar 24, 2021
@jankapunkt
Copy link
Collaborator

I added the hmr and the beta, actually get the following message in a constant interval:

Firefox can’t establish a connection to the server at ws://localhost:3000/__meteor__hmr__/websocket. hot-module-replacement.js:290:11
error
​
bubbles: false
​
cancelBubble: false
​
cancelable: false
​
composed: false
​
currentTarget: null
​
defaultPrevented: false
​
eventPhase: 0
​
explicitOriginalTarget: WebSocket { url: "ws://localhost:3000/__meteor__hmr__/websocket", readyState: 3, bufferedAmount: 0, … }
​
isTrusted: true
​
originalTarget: WebSocket { url: "ws://localhost:3000/__meteor__hmr__/websocket", readyState: 3, bufferedAmount: 0, … }
​
returnValue: true
​
srcElement: WebSocket { url: "ws://localhost:3000/__meteor__hmr__/websocket", readyState: 3, bufferedAmount: 0, … }
​
target: WebSocket { url: "ws://localhost:3000/__meteor__hmr__/websocket", readyState: 3, bufferedAmount: 0, … }
​
timeStamp: 154742
​
type: "error"
​
<get isTrusted()>: function isTrusted()
​
<prototype>: EventPrototype { composedPath: composedPath(), stopPropagation: stopPropagation(), stopImmediatePropagation: stopImmediatePropagation(), … }

HMR: websocket closed hot-module-replacement.js:294:13

@filipenevola
Copy link
Collaborator Author

@jankapunkt are you running Meteor 2 or newer?

cc @zodern

@zodern
Copy link
Collaborator

zodern commented Mar 24, 2021

@jankapunkt you need to restart Meteor after adding the hot-module-replacement package so Meteor starts the HMR Server.

@jankapunkt
Copy link
Collaborator

@zodern thx that works, didn't read carefully enough and just added the packages via editing .meteor/packages besides that there are no issues found yet. However, I have another app where I intercept/override lots of Template.prototype functions so I will check this out as well.

@jankapunkt
Copy link
Collaborator

@filipenevola is there something left that needs to be done to move forward 2.4? Anywhere where we can help? The HMR is working really smooth so far, still no errors, even with my packages that hook deeply into the Templates.

@filipenevola
Copy link
Collaborator Author

@filipenevola is there something left that needs to be done to move forward 2.4? Anywhere where we can help? The HMR is working really smooth so far, still no errors, even with my packages that hook deeply into the Templates.

There is nothing left. We are going to release in the next days. 💪

@filipenevola filipenevola merged commit 8e1eb8c into master Apr 12, 2021
@filipenevola
Copy link
Collaborator Author

Blaze 2.4 is out!

New versions:

Published htmljs@1.1.0.                       
Publishing html-tools                         
Published html-tools@1.1.0.                                                        
Publishing blaze-tools                        
Published blaze-tools@1.1.0.                                                       
Publishing spacebars-compiler                 
spacebars-compiler: updating npm dependencies -- uglify-js...                      
Published spacebars-compiler@1.2.0.           
Publishing templating-tools                   
Published templating-tools@1.2.0.                                                  
Publishing caching-html-compiler              
Published caching-html-compiler@1.2.0.                                             
Publishing static-html                        
Published static-html@1.3.0.                                                       
Publishing blaze                              
Published blaze@2.4.0.                        
Publishing spacebars                          
Published spacebars@1.1.0.                                                         
Publishing templating-compiler                
Published templating-compiler@1.4.0.          
Publishing templating-runtime                 
Published templating-runtime@1.4.0.                                                
Publishing blaze-hot                          
Published blaze-hot@1.0.0.                                                         
Publishing templating                         
Published templating@1.4.0.                   
Publishing spacebars-tests                    
Published spacebars-tests@1.2.0.                                                   
Publishing blaze-html-templates               
Published blaze-html-templates@1.2.0.         

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-development We are already working on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants